Add a warning callout when deleting managed assets #207329
Conversation
sabarasaba
added
Feature:Index Management
There was a problem hiding this comment.
Hey @sabarasaba! I left a few suggestions, lmk how it sounds to you!
src/platform/packages/shared/kbn-management/delete_managed_assets_callout/README.mdx
Outdated
Show resolved
Hide resolved
...latform/packages/shared/kbn-management/delete_managed_assets_callout/src/callout.stories.tsx
Outdated
Show resolved
Hide resolved
...latform/packages/shared/kbn-management/delete_managed_assets_callout/src/callout.stories.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-management/delete_managed_assets_callout/src/callout.tsx
Outdated
Show resolved
Hide resolved
…ets_callout/src/callout.tsx Co-authored-by: florent-leborgne <[email protected]>
…ets_callout/README.mdx Co-authored-by: florent-leborgne <[email protected]>
…ets_callout/src/callout.stories.tsx Co-authored-by: florent-leborgne <[email protected]>
…ets_callout/src/callout.stories.tsx Co-authored-by: florent-leborgne <[email protected]>
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
cc @sabarasaba |
There was a problem hiding this comment.
Thanks for improving this @sabarasaba! Tested locally and the modal looks good for both index templates and ingest pipelines. However, in index templates, I noticed that I'm not able to actually delete the template - clicking the Delete button doesn't do anything:
Screen.Recording.2025-01-24.at.21.28.58.mov
I am able to delete managed templates on main. Would it be possible that this PR causes this behavior?
src/platform/packages/shared/kbn-management/delete_managed_assets_callout/src/callout.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for having a look @ElenaStoeva, seems I forgot to add a schema param 7b5e01d |
There was a problem hiding this comment.
Thanks for addressing my feedback @sabarasaba! Latest changes lgtm and the deletion of index templates works now.
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit c8bd387) # Conflicts: # .github/CODEOWNERS # tsconfig.base.json # yarn.lock
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…208491) # Backport This will backport the following commits from `main` to `8.x`: - [Add a warning callout when deleting managed assets (#207329)](#207329) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-28T08:46:58Z","message":"Add a warning callout when deleting managed assets (#207329)","sha":"c8bd387668ed3e6fe0fd71ec9cfbc5be58bbfc5c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","Feature:Ingest Node Pipelines","backport:prev-minor"],"title":"Add a warning callout when deleting managed assets","number":207329,"url":"https://github.com/elastic/kibana/pull/207329","mergeCommit":{"message":"Add a warning callout when deleting managed assets (#207329)","sha":"c8bd387668ed3e6fe0fd71ec9cfbc5be58bbfc5c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207329","number":207329,"mergeCommit":{"message":"Add a warning callout when deleting managed assets (#207329)","sha":"c8bd387668ed3e6fe0fd71ec9cfbc5be58bbfc5c"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
added
v8.18.0
and removed
backport missing
Fixes #203154
Summary
This PR improves the confirmation modal for deleting managed index templates and ingest pipelines by using a small warning callout for adding context about Elasticsearch’s behavior of automatically recreating these assets and making sure users understand that deletions are processed but the assets will be recreated automatically.
The list of assets to be deleted in the deletion confirmation modal now also shows which ones are managed and which ones aren't.